Skip to content

[build] Bumping vllm version to 0.7.0 #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Conversation

oandreeva-nv
Copy link
Contributor

What does the PR do?

Moving our base vllm version to the latest.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Related PR on vllm backend: triton-inference-server/vllm_backend#81

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 23116416

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@oandreeva-nv oandreeva-nv added the build Issues pertaining to builds label Jan 28, 2025
@oandreeva-nv oandreeva-nv marked this pull request as ready for review January 29, 2025 22:47
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the openai *version too 🚀

@oandreeva-nv
Copy link
Contributor Author

@rmccorm4 I've updated only version we were using, not examples. Should I do examples as well somewhere?

@rmccorm4
Copy link
Contributor

rmccorm4 commented Jan 29, 2025

I meant thanks for updating the openai version* in the code and verifying that it passed 🙏

@nvda-mesharma
Copy link
Contributor

Did we measure perf for this new version?

@oandreeva-nv
Copy link
Contributor Author

@nvda-mesharma This is not currently a priority for immediate merge. During 25.01 we've found API changes in later vllm versions and requirements for the later openai library.

I'll run benchmarks to see if there's any regression for public vllm, but for dlfw vllm we'd need to re-run benchmarks in a release candidate

@oandreeva-nv oandreeva-nv merged commit 89495a3 into main Feb 13, 2025
3 checks passed
@oandreeva-nv oandreeva-nv deleted the oandreeva_vllm_0.6.5 branch February 13, 2025 23:25
nv-kmcgill53 added a commit that referenced this pull request Feb 14, 2025
Co-authored-by: Olga Andreeva <124622579+oandreeva-nv@users.noreply.github.com>
nv-kmcgill53 added a commit that referenced this pull request Mar 3, 2025
Co-authored-by: Olga Andreeva <124622579+oandreeva-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues pertaining to builds
Development

Successfully merging this pull request may close these issues.

3 participants