[fix] Adjusting VllmStatLogger for 0.7.0 changes in API #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
oandreeva-nv
changed the title
rmccorm4
reviewed
Jan 29, 2025
Comment on lines
+193
to
+194
| self.assertIn("vllm:request_params_n_count", metrics_dict) | ||
| self.assertIn("vllm:request_params_n_bucket", metrics_dict) |
There was a problem hiding this comment.
Could you summarize in the description what broke/changed about the values we were checking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Adjusting metrics-related codebase to work with some API changes in latest vllm.
Removing number check in metrics tests in favor of just checking that vllm - related metrics are populated on metrics endpoint.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
server: triton-inference-server/server#7978
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)