-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steady state callback #601
Steady state callback #601
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
==========================================
- Coverage 68.71% 68.47% -0.25%
==========================================
Files 86 87 +1
Lines 5299 5360 +61
==========================================
+ Hits 3641 3670 +29
- Misses 1658 1690 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one mistake in the condition since you pop/push the current ekin one value is always 0.0 which will effectively reduce the interval size by one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use terminate!
and then we wait for the next release of StrideArrays.jl to be able to use the latest version of DiffEqCallbacks.jl, which fixes the error.
Also, this PR is missing a test. I think it should be sufficient to run the hydrostatic water column with the steady state callback, once with interval
and once with dt
.
I tested the callback with the
pipe_flow_2d.jl
example. It terminates after~0.8sec
.I consider the change in kinetic energy in a
0.002*10
interval.