Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reconnect when auth error occurs in runDropStage method #82

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

yas-okadatech
Copy link
Contributor

No description provided.

@yas-okadatech yas-okadatech marked this pull request as draft November 7, 2024 07:59
@yas-okadatech yas-okadatech changed the title [WIP] fix: reconnect when auth error occurs in runDropStage method Nov 7, 2024
@yas-okadatech yas-okadatech marked this pull request as ready for review November 7, 2024 09:25
@yas-okadatech yas-okadatech self-assigned this Nov 7, 2024
Copy link
Contributor

@NamedPython NamedPython left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribute! LGTM!

monologue

I suggested runDropStageWithRecovery naming, but actual recovery will only happens in one case at this time. So it could be make someone confused. Sorry.

@NamedPython NamedPython merged commit b7ab45d into main Nov 7, 2024
1 check passed
@NamedPython NamedPython deleted the 24500-reconnect branch November 7, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants