Support Embulk 0.9 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3t5u
force-pushed
the
support_embulk_0_9
branch
from
f95cfdd to
e247db1
Compare
t3t5u
commented
Sep 6, 2024
| // Use toPlainString to avoid scientific notation | ||
| String s = BigDecimal.valueOf(value).toPlainString(); | ||
| // Remove the trailing zeros of the zero scale value | ||
| // See: https://docs.oracle.com/javase/8/docs/api/java/math/BigDecimal.html#toPlainString-- |
There was a problem hiding this comment.
Fetched from the following PRs.
trocco-io/embulk-parser-poi_excel#5
trocco-io/embulk-parser-poi_excel#6
t3t5u
commented
Sep 6, 2024
| @@ -300,7 +300,7 @@ private List<String> resolveSheetName(Workbook workbook, List<String> sheetNames | |||
| protected void run(PluginTask task, Schema schema, FileInput input, Workbook workbook, List<String> sheetNames, PageOutput output) { | |||
| final int flushCount = task.getFlushCount(); | |||
|
|
|||
| try (PageBuilder pageBuilder = Exec.getPageBuilder(Exec.getBufferAllocator(), schema, output)) { | |||
| try (PageBuilder pageBuilder = new PageBuilder(Exec.getBufferAllocator(), schema, output)) { | |||
There was a problem hiding this comment.
Embulk 0.9 does not have the org.embulk.spi.Exec.getPageBuilder method.
NamedPython
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.