Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks to improve flow and clarity #278

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

gregorgorjanc
Copy link
Member

I read the what_is.md the other day and thought these edits would improve flow and add clarity for those that lack some training in tree-stuff. Take what you find useful.

biological principles of inheritance, DNA duplication, and recombination; they can be
created by [evolutionary simulation](https://tskit.dev/software/#simulate) or by
[inferring genealogies from empirical DNA data](https://tskit.dev/software/#infer).
biological principles of inheritance, DNA duplication, mutation, and recombination;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make it clear that mutation is also important.

@@ -85,8 +85,9 @@ Tree sequences are used to encode and analyse large genetic datasets
Tree sequences provide an efficient way of storing
[genetic variation](https://en.wikipedia.org/wiki/Genetic_variation) data, and can
power analyses of millions of whole [genomes](https://en.wikipedia.org/wiki/Genome).
Plots (a) and (b) summarize results presented
[further](plot_storing_everyone) [down](plot_incremental_calculation) this tutorial.
Plots (a) and (b) below summarize these aspects
Copy link
Member Author

@gregorgorjanc gregorgorjanc Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this bit to now flow well.

@benjeffery
Copy link
Member

Thanks, all LGTM. I'll wait for @hyanwong to merge as I think he wrote the original

position on the chromosome. We can mark these extra "ancestral genomes" on our tree
diagrams, distinguishing them from the *sampled* genomes ($\mathrm{a}$ to $\mathrm{j}$)
by using circular symbols. We can even colour the nodes by the population that we know
which is a MRCA of the descendant genomes at that position on the chromosome.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't define MRCA anywhere previously, do we? So I think we do need to spell it out here.

@@ -187,8 +195,8 @@ In fact, succinct tree sequences don't store each tree separately, but instead a
based on an interconnected *genetic genealogy*, in which
[genetic recombination](https://en.wikipedia.org/wiki/Genetic_recombination) has led
to different regions of the chromosome having different histories. Another way of
thinking about the tree sequence above is that it describes the full genetic
*family "tree"* (strictly, "network") of our 10 genomes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's helpful to mention "network" somewhere, as that's in the title. I also think a "genetic family tree" is worth mentioning somewhere, but perhaps not here. I'm happy to merge this and add something like this sentence in again at the top.

Copy link
Member

@hyanwong hyanwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally. Happy to merge and add in any extra changes later

@hyanwong
Copy link
Member

Thanks, all LGTM. I'll wait for @hyanwong to merge as I think he wrote the original

I don't think I have permissions to merge on this repo @benjeffery. Perhaps I should have?

@benjeffery
Copy link
Member

I don't think I have permissions to merge on this repo @benjeffery. Perhaps I should have?

Invite sent!

@hyanwong hyanwong merged commit a340e52 into tskit-dev:main Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants