Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update msg and srv definitions #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update msg and srv definitions #8

wants to merge 6 commits into from

Conversation

ar13pit
Copy link
Contributor

@ar13pit ar13pit commented May 17, 2019 •
edited
Loading

Resolves #18

@ar13pit ar13pit changed the base branch from rgo2019 to master May 28, 2019 20:16
LoyVanBeek
LoyVanBeek requested changes Jun 8, 2019
View reviewed changes
people_recognition_msgs/msg/Person2D.msg
@@ -1,8 +0,0 @@
string name
uint8 age
uint8 gender
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define an enum/constants for the genders? Eg. FEMALE=0, MALE=1 ?

@ar13pit ar13pit added the hold label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoyVanBeek LoyVanBeek LoyVanBeek requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine 2D and 3D msg and srv
2 participants
@ar13pit @LoyVanBeek