Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(people) get rid of implementation names #79

Merged
merged 1 commit into from
Mar 19, 2024
Merged

(people) get rid of implementation names #79

merged 1 commit into from
Mar 19, 2024

Conversation

MatthijsBurgh
Copy link
Member

No description provided.

@MatthijsBurgh MatthijsBurgh marked this pull request as ready for review March 19, 2024 17:54
P-ict0
P-ict0 reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@P-ict0 P-ict0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to change to not shortened names?:
e.g. face_rec_srv_name -> face_recognition_srv_name

iasonth95
iasonth95 previously approved these changes Mar 19, 2024
View reviewed changes
@MatthijsBurgh MatthijsBurgh merged commit 902b008 into master Mar 19, 2024
2 checks passed
@MatthijsBurgh MatthijsBurgh deleted the pose_estimation branch March 19, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-ict0 P-ict0 P-ict0 approved these changes

@iasonth95 iasonth95 iasonth95 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthijsBurgh @iasonth95 @P-ict0