Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urdf.xacro should be reserved for files that generate a valid URDF description. #321

Open
galou opened this issue Dec 6, 2023 · 1 comment · May be fixed by #326
Open

urdf.xacro should be reserved for files that generate a valid URDF description. #321

galou opened this issue Dec 6, 2023 · 1 comment · May be fixed by #326
Assignees
Labels
enhancement New feature or request

Comments

@galou
Copy link
Contributor

galou commented Dec 6, 2023

Describe the the feature you would like

By convention, files with the suffix .urdf.xacro should be reserved for files that will allow to generate a valid URDF description, i.e. files xacro will be called with. Files that only define macros should be called .xacro or _macro.xacro. So, tower_sensor_plate.urdf.xacro, tower_standoff.urdf.xacro, and weight_block.urdf.xacro should be renamed tower_sensor_plate.xacro, tower_standoff.xacro, and weight_block.xacro.

Other notes

I can do the changes.

@galou galou added the enhancement New feature or request label Dec 6, 2023
@hilary-luo
Copy link
Contributor

Go ahead and make a PR, thanks

@galou galou linked a pull request Dec 12, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants