Fix Gazebo vendor packages usage #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
tonybaltovski
requested review from
civerachb-cpr
and removed request for
hilary-luo
civerachb-cpr
approved these changes
Sep 19, 2024
|
Thanks for this! Everything looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was testing the use of upcoming Gazebo Ionic with current jazzy branch (it is using Gazebo Harmonic by default) and found that the use of the new vendor packages could be improved and corrected according to https://gazebosim.org/docs/ionic/ros2_gz_vendor_pkgs/#cmakelists-txt-for-building-with-gazebo-vendor-packages
Type of change
How Has This Been Tested?
I test the compilation using Gazebo Ionic in a docker container. Note the the use of Ionic is still affected by gazebosim/gz-msgs#463 so compilation can not succeed even with this PR.
Checklist