Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted from .format() to using requests.get params to build dictionary of url paramters #15

Merged
merged 10 commits into from
Jul 22, 2022

Conversation

reyg3
Copy link
Member

@reyg3 reyg3 commented Jul 6, 2022

No description provided.

@reyg3 reyg3 requested a review from lboeman July 6, 2022 14:33
Copy link
Member

@lboeman lboeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a couple comments that aren't blockers. I'll try to run it later today and respond with any more comments or approve.

monsoon.py Show resolved Hide resolved
monsoon.py Outdated Show resolved Hide resolved
@reyg3 reyg3 self-assigned this Jul 6, 2022
@reyg3 reyg3 added the enhancement New feature or request label Jul 6, 2022
@reyg3 reyg3 requested a review from lboeman July 20, 2022 00:47
@reyg3 reyg3 merged commit f266a0c into main Jul 22, 2022
@reyg3 reyg3 deleted the requests-params branch May 4, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants