Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for an optional name pronunciation field so staff can see how a student’s name is said during queue interactions.
For queue display, I used inline text (Name (Pronunciation)) to keep this PR simple and readable on both desktop and mobile.
Alternative considered: a speaker icon with a tooltip for pronunciation. I did not implement that in this PR because tooltip-based interactions can be harder to use reliably on mobile (tap/hover behaviour and discoverability), and the queue page is already very busy. I can implement that option if preferred.
Motivation / Context: The main goal is to help staff pronounce student names correctly while helping students in the queue. The queue is the most important place for this, and roster support is included as a secondary display point.
Closes #85
Screenshots:
Type of change
yarn installHow Has This Been Tested?
Manual Testing
Automated Tests
Checklist:
console.logs, leftover unused logic, or anything else that was accidentally committed)