Update Gradle & AGP to version 8 #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in gradle.properties were made by the migration tool. This also disables the weaving of Cats, as transform API were disabled in AGP. Note that somehow the classes are still present, but actually triggering transformation results in an error. Cat weaving is fixed in a different way in the next commit.
We should be really moving away from AspectJ. However, for now there are no ready replacements for Cats, unless we are willing to get rid of annotation-based logging. Perhaps in the future Krang could be an option. Meanwhile, Android AspectJ Gradle Plugin seems to be actually working with AGP 8. Unfortunately, it is no longer maintained, but hopefully it can serve us at least until the next major version bump of AGP. AAGP: https://github.com/Ibotta/gradle-aspectj-pipeline-plugin Krang: https://github.com/milis92/Krang
This is obsolete with AGP 8
No longer needed as EventBus apparently supports AndroidX since 3.3
This fixes the following warning warning: The option setting 'android.defaults.buildfeatures.buildconfig=true' is deprecated. The current default is 'false'. It will be removed in version 9.0 of the Android Gradle plugin. You can resolve this warning in Android Studio via `Refactor` > `Migrate BuildConfig to Gradle Build Files`
mhoran
approved these changes
Feb 18, 2024
zopieux
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to go forward. See individual commit messages.