Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle & AGP to version 8 #575

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Update Gradle & AGP to version 8 #575

merged 7 commits into from
Feb 23, 2024

Commits on Feb 18, 2024

  1. Update Gradle & AGP to version 8 

    The changes in gradle.properties were made by the migration tool.

This also disables the weaving of Cats, as transform API were disabled
in AGP. Note that somehow the classes are still present, but actually
triggering transformation results in an error.

Cat weaving is fixed in a different way in the next commit.
    @oakkitten
    oakkitten committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    300851e View commit details
    Browse the repository at this point in the history

  2. Use Android AspectJ Gradle Plugin to keep Cats 

    We should be really moving away from AspectJ. However, for now there are
no ready replacements for Cats, unless we are willing to get rid of
annotation-based logging. Perhaps in the future Krang could be an option.

Meanwhile, Android AspectJ Gradle Plugin seems to be actually working
with AGP 8. Unfortunately, it is no longer maintained, but hopefully it can
serve us at least until the next major version bump of AGP.

AAGP: https://github.com/Ibotta/gradle-aspectj-pipeline-plugin
Krang: https://github.com/milis92/Krang
    @oakkitten
    oakkitten committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    43e41a1 View commit details
    Browse the repository at this point in the history

  3. Remove explicit Kotlin linter version pin 

    This is obsolete with AGP 8
    @oakkitten
    oakkitten committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    38fa6bb View commit details
    Browse the repository at this point in the history

  4. Disable Jetifier 

    No longer needed as EventBus apparently supports AndroidX since 3.3
    @oakkitten
    oakkitten committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    05713fb View commit details
    Browse the repository at this point in the history

  5. Fix warning about android.defaults.buildfeatures.buildconfig=true 

    This fixes the following warning warning:

The option setting
'android.defaults.buildfeatures.buildconfig=true' is
deprecated. The current default is 'false'. It will be
removed in version 9.0 of the Android Gradle plugin.
You can resolve this warning in Android Studio via
`Refactor` > `Migrate BuildConfig to Gradle Build
Files`
    @oakkitten
    oakkitten committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    6f1d8ad View commit details
    Browse the repository at this point in the history

  6. Use non-transitive R classes 

    See https://blog.blundellapps.co.uk/speed-up-your-build-non-transitive-r-files/
    @oakkitten
    oakkitten committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    80f623b View commit details
    Browse the repository at this point in the history

  7. Add comment on android.nonFinalResIds=false

    @oakkitten
    oakkitten committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    da63de3 View commit details
    Browse the repository at this point in the history