Merge pull request #28 from gentlementlegen/fix/character-escaping

fix: more characters are escaped (backtick, ampersand)
ubiquity-os-marketplace · Jun 3, 2024 · 10c7f78 · 10c7f78 · github-actions · Jun 3, 2024
2 parents ca12c26 + 550869c
commit 10c7f78
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/parser/github-comment-module.ts b/src/parser/github-comment-module.ts
@@ -121,9 +121,13 @@ export class GithubCommentModule implements Module {
 
     function buildIncentiveRow(commentScore: GithubCommentScore) {
       // Properly escape carriage returns for HTML rendering
-      const formatting = stringify(commentScore.score?.formatting?.content).replace(/[\n\r]/g, "&#13;");
+      const formatting = stringify(commentScore.score?.formatting).replace(/[\n\r]/g, "&#13;");
       // Makes sure any HTML injected in the templated is not rendered itself
-      const sanitizedContent = commentScore.content.replaceAll("<", "&lt;").replaceAll(">", "&gt;");
+      const sanitizedContent = commentScore.content
+        .replaceAll("&", "&amp;")
+        .replaceAll("<", "&lt;")
+        .replaceAll(">", "&gt;")
+        .replaceAll("`", "&#96;");
       return `
           <tr>
             <td>
File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	77.92	66.19	81.05	78.12
src	75.92	80	73.33	77.88
get-authentication-token.ts	100	100	100	100
github-types.ts	100	100	100	100
index.ts	25	100	0	25	6–10
issue-activity.ts	96.07	81.81	100	96	46–47
run.ts	60	75	100	60	23–29
start.ts	54.54	50	57.14	60	62–63, 100–118, 130
src/configuration	83.33	50	100	82.6
comment-types.ts	0	0	0	0
config-reader.ts	66.66	50	100	66.66	12, 20–22
constants.ts	100	100	100	100
content-evaluator-config.ts	100	100	100	100
data-purge-config.ts	100	100	100	100
formatting-evaluator-config.ts	100	100	100	100
github-comment-config.ts	100	100	100	100
incentives.ts	100	100	100	100
permit-generation-configuration.ts	100	100	100	100
user-extractor-config.ts	100	100	100	100
src/data-collection	83.33	65.38	100	82.85
collect-linked-pulls.ts	83.33	65.38	100	82.85	10, 19, 60–64
src/parser	77.43	64.18	82.14	77.14
content-evaluator-module.ts	62.68	45.45	58.33	60	23–24, 56–57, 75–112, 141–145
data-purge-module.ts	81.81	90.9	100	81.81	15–16
formatting-evaluator-module.ts	92.5	60	100	92.3	74–75, 87
github-comment-module.ts	84.74	65	100	84.74	39–50, 58–59, 68, 119
permit-generation-module.ts	66	37.5	55.55	66	50–51, 58–65, 107, 124–138, 144, 165–171, 178–179
processor.ts	91.66	83.33	100	91.66	34–35, 72
user-extractor-module.ts	76	76.19	83.33	76	16–17, 34, 47, 49–50
src/types	83.33	50	100	83.33
env-type.ts	100	100	100	100
payout.ts	80	50	100	80	18