-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimistic view claim rendering #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test from mobile. Perhaps somebody else can
I tried earlier but idk what I'm looking for honestly (and I messed it up and used prod). Could you attempt to detail exactly where the bottlenecks you experience are whenever it happens again please as it would make it slightly easier to think of other fixes or if this is going to make any difference, thanks.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Green toast is misleading. Let's just add a new info, grey, toast for as soon as the transaction is initiated to share the transaction link.
Then retain the original behavior of showing green once it's completed.
@Keyrxng This shouldn't have been merged. Can you fix? |
Need ubiquity-os-marketplace/daemon-merging#19 in to fix this problem. |
I was confused by this originally but look at my local notifications. The logic is as you describe, the notifications arrangement wasn't changed, previously we showed the link after the tx resolved and just before the The first |
This should make the UI appear quicker because we are no longer awaiting the transaction to be confirmed onchain before allowing the tx be viewed on a block explorer. The loading mechanic once the wallet prompt is confirmed should disappear almost instantly as we have the
tx.hash
already.view claim
button before we await thetx
tx