feat(ci): fix linux version metadata and make builds more reliable #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RJ Trujillo <eyecantcu@pm.me>
Signed-off-by: RJ Trujillo <eyecantcu@pm.me>
bsherman
changed the title
bsherman
changed the title
|
Oops I merged the negativo17 nvidia changes into this... Steps needed to get this ready:
|
bsherman
force-pushed
the
kernel-version-label-build
branch
from
3284d4c to
cf3849c
Compare
castrojo
approved these changes
Apr 19, 2024
EyeCantCU
approved these changes
Apr 19, 2024
bsherman
added a commit
to ublue-os/bazzite
that referenced
this pull request
Apr 19, 2024
This is required to be compatible with updates to akmods which drop the nvidia version tag from `akmods-nvidia` images. Relates: ublue-os/akmods#171
KyleGospo
pushed a commit
to ublue-os/bazzite
that referenced
this pull request
Apr 19, 2024
This is required to be compatible with updates to akmods which drop the nvidia version tag from `akmods-nvidia` images. Relates: ublue-os/akmods#171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditionally queries the upstream image or, in the case of custom kernels, the kernel which would be installed. The result of the query is the kernel version string which should be assigned to the
ostree.linuximage label.In addition, this value is passed into the Containerfile build to make it clear which version of the given kernel should be installed.
Downstream consumers of akmods (nvidia, asus, surface, bazzite, etc) can read the label to determine the specific version they should be installing, too, plus to assign the same label to their respective images.
Fixes: #156