fix: switch latest images to use ungated upstream kernel #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
castrojo
added a commit
that referenced
this pull request
Sep 29, 2024
Vanilla kernel doesn't support this, we'll get it in 6.12. Part of #1722
Merged
bsherman
approved these changes
Oct 6, 2024
castrojo
approved these changes
Oct 6, 2024
|
I like this approach since it installs our dual-signed version of the kernel even if the version is the same as upstream Fedora. |
bsherman
added a commit
that referenced
this pull request
Oct 6, 2024
PR #1722 passed all build checks, but after merging, we saw that for latest, where we use the stock upstream kernel, but with our added signature, rechunker complains of multiple kernels in /usr/lib/modules Also, the method which was being used to remove the old kernel packages does not run when building locally on a Fedora host. So trying a different approach. See: https://github.com/ublue-os/bluefin/actions/runs/11205608165/job/31145333321#step:23:233
bsherman
added a commit
that referenced
this pull request
Oct 7, 2024
This simplifies the logic around installing cached kernels by always doing it. This means that "vanilla"/"main" images will have the true vanilla kernel replaced by essentially the same package, but the repackaged version which we have signed in addition to the Fedora signature. This fixes a bug introduced in #1722 where accidentally stopped installing the cached kernels for asus/surface images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1717
This PR switches Bluerora to use the kernel version provided by upstream (still through kernel-cache), as recommended by some kernel developers.