Property Editors: Add mandatory support to Number Range (Refactor). #20570
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the inner input.
madsrasmussen
requested changes
Oct 28, 2025
|
|
||
| this.addValidator( | ||
| 'valueMissing', | ||
| () => '#validation_fieldIsMandatory', |
There was a problem hiding this comment.
To keep things consistent with the other inputs, we need to add a requiredMessage property. If it's not provided, we'll fall back to UMB_VALIDATION_EMPTY_LOCALIZATION_KEY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for the Mandatory setting in the Number Range property editor and removed the initial value assignment.
Changes