Skip to content

Property Editors: Add mandatory support to Number Range (Refactor). #20570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v17/dev
Choose a base branch
from
+21 −4
Open

Property Editors: Add mandatory support to Number Range (Refactor). #20570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5ba6bc
Added mandatory property to number range property editor and bind it …
engijlr Oct 20, 2025
df9d463
Merge branch 'v17/dev' into v17/improvement/number-range-property-edi…
madsrasmussen Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ...b.UI.Client/src/packages/core/components/input-number-range/input-number-range.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ export class UmbInputNumberRangeElement extends UmbFormControlMixin(UmbLitElemen
return this._minValue;
}

@property({ type: Boolean })
required = false;

@state()
private _maxValue?: number;

Expand Down Expand Up @@ -99,6 +102,12 @@ export class UmbInputNumberRangeElement extends UmbFormControlMixin(UmbLitElemen
return this._minValue !== undefined && this._maxValue !== undefined ? this._minValue > this._maxValue : false;
},
);

this.addValidator(
'valueMissing',
() => '#validation_fieldIsMandatory',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep things consistent with the other inputs, we need to add a requiredMessage property. If it's not provided, we'll fall back to UMB_VALIDATION_EMPTY_LOCALIZATION_KEY.

() => this.required && (this._minValue == null || this._maxValue == null),
);
}

override firstUpdated() {
Expand Down Expand Up @@ -129,7 +138,8 @@ export class UmbInputNumberRangeElement extends UmbFormControlMixin(UmbLitElemen
min=${ifDefined(this.validationRange?.min)}
max=${ifDefined(this.validationRange?.max)}
placeholder=${this._minPlaceholder}
.value=${this._minValue}
?required=${this.required}
.value=${this._minValue?.toString() ?? ''}
@input=${this.#onMinInput}></uui-input>
<b>–</b>
<uui-input
Expand All @@ -138,7 +148,8 @@ export class UmbInputNumberRangeElement extends UmbFormControlMixin(UmbLitElemen
min=${ifDefined(this.validationRange?.min)}
max=${ifDefined(this.validationRange?.max)}
placeholder=${this._maxPlaceholder}
.value=${this._maxValue}
?required=${this.required}
.value=${this._maxValue?.toString() ?? ''}
@input=${this.#onMaxInput}></uui-input>
`;
}
Expand Down
10 changes: 8 additions & 2 deletions ...ent/src/packages/property-editors/number-range/property-editor-ui-number-range.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,12 @@ export class UmbPropertyEditorUINumberRangeElement
@state()
private _validationRange?: UmbNumberRangeValueType;

@property({ type: Boolean })
mandatory = false;

@property({ type: Object })
public override set value(value: UmbNumberRangeValueType | undefined) {
super.value = value || { min: undefined, max: undefined };
super.value = value;
this._minValue = value?.min;
this._maxValue = value?.max;
}
Expand All @@ -42,7 +45,9 @@ export class UmbPropertyEditorUINumberRangeElement
}

#onChange(event: CustomEvent & { target: UmbInputNumberRangeElement }) {
this.value = { min: event.target.minValue, max: event.target.maxValue };
const min = event.target.minValue;
const max = event.target.maxValue;
this.value = min == null && max == null ? undefined : { min, max };
this.dispatchEvent(new UmbChangeEvent());
}

Expand All @@ -59,6 +64,7 @@ export class UmbPropertyEditorUINumberRangeElement
<umb-input-number-range
.minValue=${this._minValue}
.maxValue=${this._maxValue}
?required=${this.mandatory}
.validationRange=${this._validationRange}
@change=${this.#onChange}>
</umb-input-number-range>
Expand Down
Loading