Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: htsget elsa changes and build changes #198

Merged
merged 25 commits into from
Sep 6, 2023
Merged

feat: htsget elsa changes and build changes #198

merged 25 commits into from
Sep 6, 2023

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Sep 6, 2023 •
edited
Loading

This is mostly merging some old changes from the htsget-elsa branch.

Changes from the Elsa branch

  • Separate config parsing into a more generalized parser construct.
  • Refactor lambda service functions so that they are more usable as dependencies.
  • Add aws-mocks into htsget-test.

New changes

  • Update dependencies, including rustls 0.20 -> 0.21.
  • Add pre-commit hooks (most of the changes at the start are just style changes from pre-commit).
  • Attempt to move htsget-test to a dev-dependency - this might break deploy, but I can revert if needed.

@mmalenic
feat(config): add generalized parser for figment config
797643f
@mmalenic
feat(config): add raw environment variable provider for parser
92e6ddf
@mmalenic
feat(lambda): add handle request from service fn
d2d9aa7
@mmalenic
feat(lambda)!: move route resolution to Route struct, and add better …
a3b3da8 
…fitting error responses
@mmalenic
test(lambda): add post method route tests
d5dde6d
@mmalenic
test(lambda): split up lambda routing functions
2e493ee
@mmalenic
feat(lambda): add try_from Request implementation for Route
e829b48
@mmalenic
fix(lambda): rename function
ea654ae
@mmalenic
feat(config): add file ending functions for format
e1696cf
@mmalenic
feat(config): add allow guard setter functions
a040432
@mmalenic
feat(config): add getters for route struct
70ca723
@mmalenic
test(test): add aws mock server functions
d122e33
@mmalenic
feat(test): add tmp directory s3 server function
ca86a31
@mmalenic
refactor(test): pass base path with s3 test server function
aa116b7
@mmalenic
refactor(test): add lifetimes to s3 test server function to make it u…
c058a21 
…sable.
@mmalenic
refactor(test): use pathbuf instead
c44aea2
@mmalenic
fix(test): fix incorrect test assertion
34685bc
@mmalenic
Merge branch 'main' of https://github.com/umccr/htsget-rs into feat/h…
0cfdec8 
…tsget-elsa
@mmalenic
build: bump deps including rustls 0.21
f9b65f8
@mmalenic
fix(test): http-tests feature should include htsget-config dependency
20cd42a
@mmalenic
build(deps): update msrv and attempt using htsget-test as a dev depen…
89ae87a 
…dency
@mmalenic
style: add pre-commit hook
bfc3e3b
@mmalenic mmalenic added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit e525c30 Sep 6, 2023
3 checks passed
@mmalenic mmalenic deleted the feat/htsget-elsa branch September 6, 2023 04:28
@mmalenic mmalenic mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalenic @brainstorm