Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): return empty response when reference name is in header #204

Merged
merged 4 commits into from
Oct 2, 2023
Merged

fix(search): return empty response when reference name is in header #204

merged 4 commits into from
Oct 2, 2023

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Oct 2, 2023

Closes #201

Changes

  • Return an empty response with header and EOF bytes when a reference name is found in the header but not the index, instead of returning an error.
    • Add tests for this case.
  • Fix filename for VCF tests.

brainstorm
brainstorm approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos!

@brainstorm brainstorm added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 60c2efe Oct 2, 2023
5 checks passed
@brainstorm brainstorm deleted the fix/error-no-index-pos branch November 6, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error returned when reference name is in header but has no mapped index positions
2 participants
@mmalenic @brainstorm