Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release-please #86

Merged

Conversation

mdesouky
Copy link
Collaborator

@mdesouky mdesouky commented Nov 14, 2024

Changes:

@uptickmetachu
Copy link
Collaborator

Actually we have 3 separate things we want to be releasing here!

We have:

  1. the chart
  2. the server image
  3. the cli

Historically we've been releasing all 3 with the same change.

I think we can keep doing that for now to keep things simple.

@uptickmetachu
Copy link
Collaborator

So therefore we need to make sure we are updating the multiple locations (via release please)

@mdesouky
Copy link
Collaborator Author

Actually we have 3 separate things we want to be releasing here!

We have:

  1. the chart
  2. the server image
  3. the cli

Historically we've been releasing all 3 with the same change.

I think we can keep doing that for now to keep things simple.

@uptickmetachu I've configured different releases for CLI, Server and Chart please check if the config is OK

@uptickmetachu
Copy link
Collaborator

Yup looks fine. Lets see how it goes. You'll likely need to tweak it a few times :)

@@ -0,0 +1,16 @@
{
"packages": {
"gitops": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one will actually need to be "." as pyproject.toml is located at the top level.

We'll need some excludes to gitops server now that I think about it.

I also think we might be able to skip gitops_server. We can have gitops_server building on all pushes to main.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the round trip; just given it more thought :(

uptickmetachu
uptickmetachu previously approved these changes Nov 14, 2024
.github/workflows/release-please.yaml Show resolved Hide resolved
@mdesouky mdesouky merged commit 34b5e2c into develop Nov 14, 2024
2 checks passed
@mdesouky mdesouky deleted the dev-930/automate-gitops-releases-with-release-please branch November 14, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants