-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use release-please #86
Use release-please #86
Conversation
Actually we have 3 separate things we want to be releasing here! We have:
Historically we've been releasing all 3 with the same change. I think we can keep doing that for now to keep things simple. |
So therefore we need to make sure we are updating the multiple locations (via release please) |
…e releases for CLI,Server and Chart
@uptickmetachu I've configured different releases for CLI, Server and Chart please check if the config is OK |
Yup looks fine. Lets see how it goes. You'll likely need to tweak it a few times :) |
release-please-config.json
Outdated
@@ -0,0 +1,16 @@ | |||
{ | |||
"packages": { | |||
"gitops": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one will actually need to be "." as pyproject.toml is located at the top level.
We'll need some excludes to gitops server now that I think about it.
I also think we might be able to skip gitops_server
. We can have gitops_server
building on all pushes to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the round trip; just given it more thought :(
Changes: