-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use release-please #86
Merged
mdesouky
merged 5 commits into
develop
from
dev-930/automate-gitops-releases-with-release-please
Nov 14, 2024
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0324a14
feat: Use release-please
mdesouky b7b6696
chore: Use Fix branch name
mdesouky 1d23e7a
chore: Adding an initial release-please manifest, configuring separat…
mdesouky 132790b
chore: Adding more complex release-please config
mdesouky 94e1fa5
chore: Control publishing steps with conditions according to outputs
mdesouky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
name: Release Please | ||
on: | ||
push: | ||
branches: | ||
- develop | ||
|
||
permissions: | ||
actions: read # Read the metrics | ||
contents: write # to be able to publish a GitHub release | ||
issues: write # to be able to comment on released issues | ||
pull-requests: write # to be able to comment on released pull requests | ||
id-token: write # to enable use of OIDC for npm provenance / AWS | ||
|
||
env: | ||
MISE_PYTHON_COMPILE: false | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
jobs: | ||
release_gitops_cli: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: googleapis/release-please-action@v4 | ||
id: release | ||
# Configured via: release-please-config.json and will update the manifest: .release-please-manifest.json | ||
with: {} | ||
outputs: | ||
# Root level release_created | ||
release_created: ${{ steps.release.outputs.release_created }} | ||
# Root level tag_name | ||
tag_name: ${{ steps.release.outputs.tag_name }} | ||
sha: ${{ steps.release.outputs.sha }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"gitops": "0.12.1", | ||
"gitops_server": "0.12.1", | ||
"charts/gitops": "0.12.1" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"packages": { | ||
"gitops": { | ||
"package-name": "gitops", | ||
"release-type": "python" | ||
}, | ||
"gitops_server": { | ||
"package-name": "gitops-server", | ||
"release-type": "python" | ||
}, | ||
"charts/gitops":{ | ||
"package-name": "gitops-chart", | ||
"release-type": "helm" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one will actually need to be "." as pyproject.toml is located at the top level.
We'll need some excludes to gitops server now that I think about it.
I also think we might be able to skip
gitops_server
. We can havegitops_server
building on all pushes to main.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the round trip; just given it more thought :(