Skip to content

Comments

Несмиянов Артем#32

Open
AtnesNess wants to merge 1 commit intourfu-2016:masterfrom
AtnesNess:master
Open

Несмиянов Артем#32
AtnesNess wants to merge 1 commit intourfu-2016:masterfrom
AtnesNess:master

Conversation

@AtnesNess
Copy link

@AtnesNess AtnesNess commented Apr 26, 2017

Реализован функционал и покрытие тестами функции getPokerHand

@AtnesNess AtnesNess changed the title Реализован функционал и покрытие тестами функции getPokerHand Несмиянов Артем Apr 26, 2017
Copy link

@mokhov mokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужны правки

const getPokerHand = require('../getPokerHand');

describe('getPokerHand', () => {
it('should throw `Кубиков должно быть 5` for [1, 1, 1, 1]', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не хватает тестов, проверяющих переданные данные

break;
}
}
if (pocker) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poker

counts[el]++;
}

for (el in counts) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не понял зачем так сложно?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants