-
Notifications
You must be signed in to change notification settings - Fork 33
Несмиянов Артем #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AtnesNess
wants to merge
1
commit into
urfu-2016:master
Choose a base branch
from
AtnesNess:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Несмиянов Артем #32
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,8 +6,66 @@ | |
| */ | ||
| function getPokerHand(dice) { | ||
| // Напишите ваш замечательный код здесь | ||
| if (dice && dice.length !== 5) { | ||
| throw Error('Кубиков должно быть 5'); | ||
| } | ||
|
|
||
| return 'Покер'; | ||
| let counts = {}; | ||
| let pairs = 0; | ||
| let kare = false; | ||
| let pocker = false; | ||
| let set = false; | ||
| for (let el of dice) { | ||
| if (typeof el !== 'number') { | ||
| throw Error('В кубике все грани являются числами'); | ||
| } | ||
| if (!counts[el]) { | ||
| counts[el] = 0; | ||
| } | ||
| counts[el]++; | ||
| } | ||
|
|
||
| for (el in counts) { | ||
| switch (counts[el]) { | ||
| case 2: | ||
| pairs++; | ||
| break; | ||
| case 3: | ||
| set = true; | ||
| break | ||
| case 4: | ||
| kare = true; | ||
| break; | ||
| case 5: | ||
| pocker = true; | ||
| break; | ||
| } | ||
| } | ||
| if (pocker) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. poker |
||
| return 'Покер'; | ||
| } | ||
|
|
||
| if (kare) { | ||
| return 'Каре'; | ||
| } | ||
|
|
||
| if (pairs === 1 && set) { | ||
| return 'Фулл хаус'; | ||
| } | ||
|
|
||
| if (set) { | ||
| return 'Тройка' | ||
| } | ||
|
|
||
| if (pairs === 2) { | ||
| return 'Две пары' | ||
| } | ||
|
|
||
| if (pairs === 1) { | ||
| return 'Пара' | ||
| } | ||
|
|
||
| return 'Наивысшее очко'; | ||
| } | ||
|
|
||
| module.exports = getPokerHand; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,65 @@ const assert = require('assert'); | |
| const getPokerHand = require('../getPokerHand'); | ||
|
|
||
| describe('getPokerHand', () => { | ||
| it('should throw `Кубиков должно быть 5` for [1, 1, 1, 1]', () => { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Не хватает тестов, проверяющих переданные данные |
||
|
|
||
| try { | ||
| const actual = getPokerHand([1, 1, 1, 1]); | ||
| throw Error('shoud Throw Error'); | ||
| } catch (e) { | ||
| assert.equal(e.message, 'Кубиков должно быть 5'); | ||
| } | ||
| }); | ||
|
|
||
| it('should throw `В кубике все грани являются числами` for [1, 1, 1, 1, `1`]', () => { | ||
|
|
||
| try { | ||
| const actual = getPokerHand([1, 1, 1, 1, '1']); | ||
| throw Error('shoud Throw Error'); | ||
| } catch (e) { | ||
| assert.equal(e.message, 'В кубике все грани являются числами'); | ||
| } | ||
| }); | ||
|
|
||
| it('should return `Покер` for [1, 1, 1, 1, 1]', () => { | ||
| const actual = getPokerHand([1, 1, 1, 1, 1]); | ||
|
|
||
| assert.equal(actual, 'Покер'); | ||
| }); | ||
|
|
||
| // Напишите тесты на ваш замечательный код здесь | ||
| it('should return `Каре` for [1, 1, 1, 1, 2]', () => { | ||
| const actual = getPokerHand([1, 1, 1, 1, 2]); | ||
|
|
||
| assert.equal(actual, 'Каре'); | ||
| }); | ||
|
|
||
| it('should return `Фулл хаус` for [1, 5, 1, 1, 5]', () => { | ||
| const actual = getPokerHand([1, 5, 1, 1, 5]); | ||
|
|
||
| assert.equal(actual, 'Фулл хаус'); | ||
| }); | ||
|
|
||
| it('should return `Тройка` for [1, 2, 1, 3, 1]', () => { | ||
| const actual = getPokerHand([1, 2, 1, 3, 1]); | ||
|
|
||
| assert.equal(actual, 'Тройка'); | ||
| }); | ||
|
|
||
| it('should return `Две пары` for [1, 2, 5, 1, 2]', () => { | ||
| const actual = getPokerHand([1, 2, 5, 1, 2]); | ||
|
|
||
| assert.equal(actual, 'Две пары'); | ||
| }); | ||
|
|
||
| it('should return `Пара` for [1, 2, 5, 1, 3]', () => { | ||
| const actual = getPokerHand([1, 2, 5, 1, 3]); | ||
|
|
||
| assert.equal(actual, 'Пара'); | ||
| }); | ||
|
|
||
| it('should return `Наивысшее очко` for [1, 2, 3, 4, 5]', () => { | ||
| const actual = getPokerHand([1, 2, 3, 4, 5]); | ||
|
|
||
| assert.equal(actual, 'Наивысшее очко'); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не понял зачем так сложно?