Skip to content

Conversation

mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented Sep 19, 2025

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.26%. Comparing base (f991654) to head (eba0583).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   76.30%   76.26%   -0.04%     
==========================================
  Files         130      130              
  Lines       33954    33913      -41     
==========================================
- Hits        25909    25865      -44     
- Misses       8045     8048       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkmkme
Copy link
Collaborator Author

mkmkme commented Sep 21, 2025

The CI looks good in general. The tests pass locally as well.
The only issue is uvloop: MagicStack/uvloop#637

Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
@mkmkme mkmkme changed the title Add 3.14-dev to the CI run Add Python 3.14 to CI, drop Python 3.9 Sep 25, 2025
@mkmkme mkmkme marked this pull request as ready for review September 25, 2025 18:09
@mkmkme
Copy link
Collaborator Author

mkmkme commented Sep 25, 2025

@bogdanp05 could you please take a look? This one is ready to go.

Actually hold on a sec. I'll bump the python version in other jobs as well

@mkmkme mkmkme enabled auto-merge September 25, 2025 18:10
@mkmkme mkmkme added ci and removed do-not-merge labels Sep 25, 2025
@mkmkme mkmkme disabled auto-merge September 25, 2025 18:20
@mkmkme
Copy link
Collaborator Author

mkmkme commented Sep 25, 2025

I think now it's good to go

@mkmkme mkmkme enabled auto-merge September 25, 2025 18:27
@mkmkme mkmkme disabled auto-merge September 25, 2025 18:28
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
@mkmkme mkmkme changed the title Add Python 3.14 to CI, drop Python 3.9 Add Python 3.14 and pypy-3.11 to CI, drop Python 3.9 and pypy-3.9 Sep 25, 2025
@mkmkme mkmkme enabled auto-merge September 25, 2025 19:02
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
@mkmkme
Copy link
Collaborator Author

mkmkme commented Sep 25, 2025

The latest commit is related to setuptools not being included with Python anymore. We also need to switch to pyproject.toml soon as per #96. I'll reintroduce that change soon, it's going to be released with 6.2.0

@mkmkme
Copy link
Collaborator Author

mkmkme commented Sep 25, 2025

Also "Install package from commit hash (3.9)" is expected to hang. I'll remove it from the required status as soon as this PR is merged

Copy link
Collaborator

@bogdanp05 bogdanp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdanp05
Copy link
Collaborator

"Install package from commit hash (3.9)" is a required check and if it hangs, then auto-merge will never happen

@mkmkme
Copy link
Collaborator Author

mkmkme commented Sep 25, 2025

"Install package from commit hash (3.9)" is a required check and if it hangs, then auto-merge will never happen

True. I can remove it next week as I'm out until Tuesday) or you can do it yourself if you want :)

@mkmkme mkmkme merged commit deffca0 into main Sep 25, 2025
85 checks passed
@mkmkme mkmkme deleted the mkmkme/3.14 branch September 25, 2025 21:02
@bogdanp05
Copy link
Collaborator

you can do it yourself

Done. Note to self: I had to disable it from settings -> branches -> branch protection rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants