Skip to content

ci: some fixes to make CI more stable #241

ci: some fixes to make CI more stable

ci: some fixes to make CI more stable #241

Triggered via pull request June 10, 2024 14:25
@holtgreweholtgrewe
opened #157
Status Success
Total duration 10s
Artifacts

conventional-prs.yml

on: pull_request_target
title-format
2s
title-format
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 8 warnings
item in documentation is missing backticks: src/simulate/mod.rs#L30
error: item in documentation is missing backticks --> src/simulate/mod.rs:30:24 | 30 | /// Path to output RocksDB. | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown note: the lint level is defined here --> src/main.rs:2:9 | 2 | #![deny(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::doc_markdown)]` implied by `#[deny(clippy::pedantic)]` help: try | 30 | /// Path to output `RocksDB`. | ~~~~~~~~~
item in documentation is missing backticks: src/simulate/mod.rs#L30
error: item in documentation is missing backticks --> src/simulate/mod.rs:30:24 | 30 | /// Path to output RocksDB. | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown note: the lint level is defined here --> src/main.rs:2:9 | 2 | #![deny(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::doc_markdown)]` implied by `#[deny(clippy::pedantic)]` help: try | 30 | /// Path to output `RocksDB`. | ~~~~~~~~~
title-format
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: amannn/action-semantic-pull-request@v3.4.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
title-format
The following actions uses node12 which is deprecated and will be forced to run on node16: amannn/action-semantic-pull-request@v3.4.0. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
you are explicitly cloning with `.map()`: src/server/actix_server/hpo_terms.rs#L142
warning: you are explicitly cloning with `.map()` --> src/server/actix_server/hpo_terms.rs:142:26 | 142 | let definition = definition.first().map(std::clone::Clone::clone); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `definition.first().cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default
the borrowed expression implements the required traits: src/query/mod.rs#L305
warning: the borrowed expression implements the required traits --> src/query/mod.rs:305:9 | 305 | &path_rocksdb, | ^^^^^^^^^^^^^ help: change this to: `path_rocksdb` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
use of a fallible conversion when an infallible one could be used: src/algos/phenomizer.rs#L43
warning: use of a fallible conversion when an infallible one could be used --> src/algos/phenomizer.rs:43:24 | 43 | let len: f32 = len.try_into().expect("too many query terms for f32"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: converting `u16` to `f32` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default help: use | 43 - let len: f32 = len.try_into().expect("too many query terms for f32"); 43 + let len: f32 = len.into(); |
you are explicitly cloning with `.map()`: src/server/actix_server/hpo_terms.rs#L142
warning: you are explicitly cloning with `.map()` --> src/server/actix_server/hpo_terms.rs:142:26 | 142 | let definition = definition.first().map(std::clone::Clone::clone); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `definition.first().cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default
the borrowed expression implements the required traits: src/query/mod.rs#L305
warning: the borrowed expression implements the required traits --> src/query/mod.rs:305:9 | 305 | &path_rocksdb, | ^^^^^^^^^^^^^ help: change this to: `path_rocksdb` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
use of a fallible conversion when an infallible one could be used: src/algos/phenomizer.rs#L43
warning: use of a fallible conversion when an infallible one could be used --> src/algos/phenomizer.rs:43:24 | 43 | let len: f32 = len.try_into().expect("too many query terms for f32"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: converting `u16` to `f32` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default help: use | 43 - let len: f32 = len.try_into().expect("too many query terms for f32"); 43 + let len: f32 = len.into(); |