ci: some fixes to make CI more stable #241
clippy
1 error, 3 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 1 |
| Warning | 3 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956 2024-04-29)
Annotations
Check failure on line 30 in src/simulate/mod.rs
github-actions / clippy
item in documentation is missing backticks
error: item in documentation is missing backticks
--> src/simulate/mod.rs:30:24
|
30 | /// Path to output RocksDB.
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
--> src/main.rs:2:9
|
2 | #![deny(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::doc_markdown)]` implied by `#[deny(clippy::pedantic)]`
help: try
|
30 | /// Path to output `RocksDB`.
| ~~~~~~~~~
Check warning on line 142 in src/server/actix_server/hpo_terms.rs
github-actions / clippy
you are explicitly cloning with `.map()`
warning: you are explicitly cloning with `.map()`
--> src/server/actix_server/hpo_terms.rs:142:26
|
142 | let definition = definition.first().map(std::clone::Clone::clone);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `definition.first().cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
Check warning on line 305 in src/query/mod.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/query/mod.rs:305:9
|
305 | &path_rocksdb,
| ^^^^^^^^^^^^^ help: change this to: `path_rocksdb`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 43 in src/algos/phenomizer.rs
github-actions / clippy
use of a fallible conversion when an infallible one could be used
warning: use of a fallible conversion when an infallible one could be used
--> src/algos/phenomizer.rs:43:24
|
43 | let len: f32 = len.try_into().expect("too many query terms for f32");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: converting `u16` to `f32` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
help: use
|
43 - let len: f32 = len.try_into().expect("too many query terms for f32");
43 + let len: f32 = len.into();
|