Update versions and fix style #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
wmdietl
commented
Jan 16, 2025
| @@ -106,10 +106,10 @@ protected boolean canUpdate(Node lhsNode, Node rhsNode, CFValue lhsValue) { | |||
| atypeFactory.getAnnotationMirror(rhsNode.getTree(), Unique.class); | |||
| if (lhsAMUnique != null && rhsAMUnique != null && lhsValue != null) { | |||
| for (AnnotationMirror lhsAnno : lhsValue.getAnnotations()) { | |||
| if (AnnotationUtils.areSameByName(atypeFactory.UNIQUE, lhsAnno)) { | |||
| if (AnnotationUtils.areSameByName(linearAtypeFactory.UNIQUE, lhsAnno)) { | |||
| List<String> lhsStatesList = | |||
| AnnotationUtils.getElementValueArray( | |||
There was a problem hiding this comment.
The deprecated version that takes the executable name allows getting default value, by passing true as last argument.
The suggested replacement only takes a default value, leading to duplication between the qualifier declaration and all these uses.
This use doesn't provide a default, which can fail at runtime.
I've filed eisop/checker-framework#1064 to clean this up.
Ao-senXiong
reviewed
Jan 16, 2025
| @@ -36,7 +36,7 @@ public boolean updateNodeValues(Node node, TransferResult<CFValue, CFStore> tran | |||
|
|
|||
| // TODO: there is a bug, the lhs node should be updated later, think about a way to do it. | |||
| if (node instanceof AssignmentNode) { | |||
| Node rhsNode = ((AssignmentNode) node).getExpression(); | |||
| // Node rhsNode = ((AssignmentNode) node).getExpression(); | |||
There was a problem hiding this comment.
If we are not using this variable, should we delete it instead of comment out?
| annotationMirror, atypeFactory.ensureUniqueValueElement, String.class); | ||
| // TODO: there currently is no example for this error. | ||
| // The check does not pass Error Prone - there is a mismatch between what postStates contains | ||
| // and what transition.get returns. |
There was a problem hiding this comment.
This looks really bad as we don't have any test cases for it:(
There was a problem hiding this comment.
Yes, that's what the TODO comment says.
I filed #18 for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.