-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release versoview to github releases #203
Conversation
Is there any artifact or release uploaded successfully from your fork? |
Still testing, it takes way too long to build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it finally worked, https://github.com/Legend-Master/verso/releases/tag/versoview-v0.0.1
Good run https://github.com/Legend-Master/verso/actions/runs/11361145367, I removed and re-released to https://github.com/Legend-Master/verso/releases/tag/versoview-v0.0.1 |
I think we can take this chance to swap the crate names to test if all CI could pass. |
I can try it, I think we just need to change the package names in the CI and it should work Running one at https://github.com/Legend-Master/verso/actions/runs/11397055642 |
I think it worked Legend-Master@6cb27dd |
Could you change the crate names in this PR? |
I'm not quite sure what you want, I can swap the crate names but isn't it just for testing? Swapping the names for real doesn't make much sense to me |
As discussed in zulip, the second crate should be verso actually. The name of shared binary hasn't decided yet, but I think we could swap it for now. So we can test all CIs are working when the names are different. |
Kinda get it now, so the 'core' (currently I'll get some food and be back in an hour |
The core will still produce the binary. The webview controller you mean will be named as verso. It will be both a browser and a library to provide webview api. |
Cherry picked that commit in |
No description provided.