Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release versoview to github releases #203

Merged
merged 18 commits into from
Oct 22, 2024

Conversation

Legend-Master
Copy link
Contributor

No description provided.

@Legend-Master Legend-Master marked this pull request as ready for review October 15, 2024 09:03
@wusyong
Copy link
Member

wusyong commented Oct 15, 2024

Is there any artifact or release uploaded successfully from your fork?

@Legend-Master Legend-Master marked this pull request as draft October 15, 2024 13:52
@Legend-Master
Copy link
Contributor Author

Still testing, it takes way too long to build

@Legend-Master Legend-Master marked this pull request as ready for review October 15, 2024 14:23
Copy link
Contributor Author

@Legend-Master Legend-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/release-versoview.yml Outdated Show resolved Hide resolved
.github/workflows/release-versoview.yml Outdated Show resolved Hide resolved
@Legend-Master
Copy link
Contributor Author

@Legend-Master Legend-Master marked this pull request as draft October 16, 2024 05:31
@Legend-Master Legend-Master marked this pull request as ready for review October 16, 2024 08:20
@Legend-Master
Copy link
Contributor Author

Good run https://github.com/Legend-Master/verso/actions/runs/11361145367, I removed and re-released to https://github.com/Legend-Master/verso/releases/tag/versoview-v0.0.1

@Legend-Master Legend-Master mentioned this pull request Oct 17, 2024
5 tasks
@wusyong
Copy link
Member

wusyong commented Oct 18, 2024

I think we can take this chance to swap the crate names to test if all CI could pass.
Could you rename verso to versoview for now? And vice versa.

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Oct 18, 2024

I can try it, I think we just need to change the package names in the CI and it should work

Running one at https://github.com/Legend-Master/verso/actions/runs/11397055642

@Legend-Master
Copy link
Contributor Author

I think it worked Legend-Master@6cb27dd

@wusyong
Copy link
Member

wusyong commented Oct 22, 2024

I think it worked Legend-Master@6cb27dd

Could you change the crate names in this PR?

@Legend-Master
Copy link
Contributor Author

I'm not quite sure what you want, I can swap the crate names but isn't it just for testing? Swapping the names for real doesn't make much sense to me

@wusyong
Copy link
Member

wusyong commented Oct 22, 2024

As discussed in zulip, the second crate should be verso actually. The name of shared binary hasn't decided yet, but I think we could swap it for now. So we can test all CIs are working when the names are different.

@Legend-Master
Copy link
Contributor Author

Kinda get it now, so the 'core' (currently verso) will be named versoview, and the current versoview will be changed to verso which will produce the binary? What about the current versoview (webview controller)? I would probably want to discuss about this a bit more before doing it

I'll get some food and be back in an hour

@wusyong
Copy link
Member

wusyong commented Oct 22, 2024

The core will still produce the binary. The webview controller you mean will be named as verso. It will be both a browser and a library to provide webview api.

@Legend-Master
Copy link
Contributor Author

Cherry picked that commit in

@wusyong wusyong added this pull request to the merge queue Oct 22, 2024
Merged via the queue into versotile-org:main with commit 8c8a794 Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants