Skip to content

Fix: Make sizeBasis optional in IconLayer type definition #9883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Make sizeBasis optional in IconLayer type definition #9883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aee0f7
Initial plan
Copilot Nov 25, 2025
1ae1c50
Make sizeBasis property optional in IconLayer type definition
Copilot Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/layers/src/icon-layer/icon-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ type _IconLayerProps<DataT> = {
/**
* The dimension to scale the image
*/
sizeBasis: 'height' | 'width';
sizeBasis?: 'height' | 'width';
/**
* The minimum size in pixels. When using non-pixel `sizeUnits`, this prop can be used to prevent the icon from getting too small when zoomed out.
*/
Expand Down
Loading