Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19 backport: Online DDL: avoid SQL's CONVERT(...), convert programmatically if needed #16603

Merged
merged 2 commits into from
Aug 15, 2024

empty commit to kick CI

e22b0d7
Select commit
Loading
Failed to load commit list.
Merged

v19 backport: Online DDL: avoid SQL's CONVERT(...), convert programmatically if needed #16603

empty commit to kick CI
e22b0d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Aug 15, 2024 in 0s

39.47% of diff hit (target 67.37%)

View this Pull Request on Codecov

39.47% of diff hit (target 67.37%)

Annotations

Check warning on line 574 in go/vt/vttablet/onlineddl/vrepl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/vrepl.go#L574 

Added line #L574 was not covered by tests

Check warning on line 576 in go/vt/vttablet/onlineddl/vrepl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/vrepl.go#L576 

Added line #L576 was not covered by tests

Check warning on line 591 in go/vt/vttablet/onlineddl/vrepl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/vrepl.go#L589-L591 

Added lines #L589 - L591 were not covered by tests

Check warning on line 600 in go/vt/vttablet/onlineddl/vrepl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/onlineddl/vrepl.go#L600 

Added line #L600 was not covered by tests

Check warning on line 327 in go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go#L324-L327 

Added lines #L324 - L327 were not covered by tests

Check warning on line 331 in go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go#L329-L331 

Added lines #L329 - L331 were not covered by tests

Check warning on line 336 in go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go#L334-L336 

Added lines #L334 - L336 were not covered by tests

Check warning on line 338 in go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go#L338 

Added line #L338 was not covered by tests

Check warning on line 349 in go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go#L349 

Added line #L349 was not covered by tests

Check warning on line 647 in go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go#L647 

Added line #L647 was not covered by tests

Check warning on line 707 in go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go#L705-L707 

Added lines #L705 - L707 were not covered by tests

Check warning on line 709 in go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go#L709 

Added line #L709 was not covered by tests
View more details on Codecov