Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19 backport: Online DDL: avoid SQL's CONVERT(...), convert programmatically if needed #16603

Merged
merged 2 commits into from
Aug 15, 2024

empty commit to kick CI

e22b0d7
Select commit
Loading
Failed to load commit list.
Merged

v19 backport: Online DDL: avoid SQL's CONVERT(...), convert programmatically if needed #16603

empty commit to kick CI
e22b0d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 15, 2024 in 0s

67.36% (-0.01%) compared to 93307a2

View this Pull Request on Codecov

67.36% (-0.01%) compared to 93307a2

Details

Codecov Report

Attention: Patch coverage is 39.47368% with 23 lines in your changes missing coverage. Please review.

Project coverage is 67.36%. Comparing base (93307a2) to head (e22b0d7).

Files Patch % Lines
...blet/tabletmanager/vreplication/replicator_plan.go 46.87% 17 Missing ⚠️
go/vt/vttablet/onlineddl/vrepl.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #16603      +/-   ##
================================================
- Coverage         67.37%   67.36%   -0.01%     
================================================
  Files              1560     1560              
  Lines            193238   193258      +20     
================================================
- Hits             130195   130190       -5     
- Misses            63043    63068      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.