Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resultsObserver to ScatterConn #16638

Merged
merged 9 commits into from
Aug 29, 2024

Don't re-use resultsObserver in CloneForMirroring

5a8f060
Select commit
Loading
Failed to load commit list.
Merged

Add resultsObserver to ScatterConn #16638

Don't re-use resultsObserver in CloneForMirroring
5a8f060
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 29, 2024 in 0s

69.00% (+0.02%) compared to feb845a

View this Pull Request on Codecov

69.00% (+0.02%) compared to feb845a

Details

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.00%. Comparing base (feb845a) to head (5a8f060).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/scatter_conn.go 69.23% 4 Missing ⚠️
go/vt/vtgate/vcursor_impl.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16638      +/-   ##
==========================================
+ Coverage   68.98%   69.00%   +0.02%     
==========================================
  Files        1562     1564       +2     
  Lines      200697   202029    +1332     
==========================================
+ Hits       138446   139411     +965     
- Misses      62251    62618     +367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.