Anbit/guidance #33
Open
Anbit/guidance #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andeshog
reviewed
Nov 13, 2025
Contributor
There was a problem hiding this comment.
log should be added to .gitignore
Andeshog
reviewed
Nov 13, 2025
Comment on lines
+1
to
+2
| #request | ||
| int8 mode # 0=PROPORTIONAL, 1=INTEGRAL, 2=ADAPTIVE |
Contributor
There was a problem hiding this comment.
I would suggest something like this
# request
uint8 PROPORTIONAL=0
uint8 INTEGRAL=1
uint8 ADAPTIVE=2
uint8 mode
---
# response
bool success
Andeshog
reviewed
Nov 13, 2025
Comment on lines
+3
to
4
| # vortex_msgs/LosActiveMethod method | ||
|
|
Contributor
There was a problem hiding this comment.
Probably better to just remove it if it is not in use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition:
In this update to the vortex_msgs package, I have added a new service definition that allows switching between different LOS guidance methods at runtime. The new service is called SetLosMode.srv and is used by the los_guidance node to select the active LOS method while the node is running.
This addition makes it possible to dynamically change between multiple LOS systems, without restarting the system or reloading parameters. It is a key step in making the LOS guidance system more flexible and modular.