Skip to content

Conversation

@RichardByrneCP
Copy link
Contributor

What is the purpose of this pull request?

This is the second of two PRs to solve a web accessibility issue for the NumberStepper input and associated label. The first PR is here: vtex-apps/product-quantity#68

This PR adds the id of "vtex-product-quantity-input" to the input element, which is labelled by the label element created in the first PR link above.

How to test it?

Check the HTML in developer console to see the changes reflected.

Workspace

Screenshots or example usage:

Screenshot 2025-08-19 at 09 54 56

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
styleguide Error Error Sep 26, 2025 5:30pm

@RichardByrneCP
Copy link
Contributor Author

Hi @vsseixaso, could you please review this as a priority as it has been 2 weeks since I updated the associated PR.
Thanks, Richard

@RichardByrneCP
Copy link
Contributor Author

RichardByrneCP commented Sep 26, 2025

@vsseixaso Thanks for the details on the new feature flag. Have implemented it into both the PRs and is working on the workspace linked in the description.
This PR has the useSemanticHTML flag passed into it via props as it would not let me re-fetch it there from runtime for some strange reason. It does avoid duplicate fetching of it though.

@matheusps matheusps merged commit 25213c8 into vtex:master Oct 1, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants