Skip to content

Add id to numeric stepper input #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
Merged

Add id to numeric stepper input #1454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81b2a7d
Add id to numeric stepper input
RichardByrneCP Sep 1, 2025
be0ddf8
Update CHANGELOG.md
RichardByrneCP Sep 1, 2025
750105c
Update index.js to use useSemanticHTML
RichardByrneCP Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

- Add id to numberic stepper input for accessibility purposes

## [9.146.13] - 2024-08-20

## [9.146.12] - 2024-08-20
Expand Down
4 changes: 4 additions & 0 deletions react/components/NumericStepper/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ class NumericStepper extends Component {
label,
lean,
readOnly,
useSemanticHtml,
} = this.props

const isMin = value <= normalizeMin(minValue)
Expand Down Expand Up @@ -285,6 +286,8 @@ class NumericStepper extends Component {
lean ? 'outline-0' : ''
} `

const semanticHtml = useSemanticHtml ? { id: 'vtex-product-quantity-input' } : {}

const content = (
<React.Fragment>
{label && (
Expand All @@ -295,6 +298,7 @@ class NumericStepper extends Component {
)}
<div className="vtex-numeric-stepper-container numeric-stepper-container flex self-start">
<input
{...semanticHtml}
type="tel"
readOnly={readOnly}
className={`vtex-numeric-stepper__input numeric-stepper__input z-1 order-1 tc bw1 ${borderClasses} br0 ${inputClasses} ${styles.hideDecorators}`}
Expand Down