Generalisation of Interpolation modules

[tjavaid]

Minor update in the interpolation macro to incorporate the more Higgs mass points and the production modes.

Need to edit the lines to select the mass points and production modes (execution command remains same as per instructions in CMSSW_10_X branch)

[ram1123]

Hi @tjavaid ,

Please edit the PR target branch of the PR. Currently you are pushing it to the master. You should push it to CMSSW_10_X

[ram1123]

Hi @tjavaid ,

This PR has some conflicts. Please resolve this. Then everything should be fine.

[tjavaid]

resolved. But I see a tab space is added once I resolved. You can see here:
https://github.com/vukasinmilosevic/Fiducial_XS/blob/CMSSW_10_X_interpolatePlus/python/interpolate_differential_pred.py#L165

Should I do git pull at the working area and then commit again after removing this ?

[ram1123]

resolved. But I see a tab space is added once I resolved. You can see here: https://github.com/vukasinmilosevic/Fiducial_XS/blob/CMSSW_10_X_interpolatePlus/python/interpolate_differential_pred.py#L165

Should I do git pull at the working area and then commit again after removing this ?

I think this will break the code. Did you check by running these modules?

Please confirm the following two points:

1. Is the updated module working fine?
2. Is the dictionaries created by new module and the old one are identical?

Once I get your response with "YES" for both question, I will check them.

[tjavaid]

yes, PR was created after checking by running the modules (for mass4l and pT4l) and was working fine.
Yes, the dictionary names are identical (had to rename to generalize for other production modes and treatment to MG5 sample was done which was not there before) as you can check here:

616eedb

[ram1123]

yes, PR was created after checking by running the modules (for mass4l and pT4l) and was working fine.

Okay. By eye it seems that there is an indentation issue. Since you said its running then it should be fine.

Yes, the dictionary names are identical (had to rename to generalize for other production modes) as you can check here:

616eedb

I am asking about the values in the output dictionary. Are they also same?

[ram1123]

Hi @tjavaid ,

Seems like you didn't update your latest macro. As your macro on the GitHub breaks.

Command: python python/interpolate_differential_pred.py --obsName="pT4l" --obsBins="|0|10|20|30|45|60|80|120|200|13000|" --year=2018
  File "python/interpolate_differential_pred.py", line 166
    f.write('acc = '+str(acc_all)+' \n')
                                       ^
IndentationError: unindent does not match any outer indentation level

[tjavaid]

yes, PR was created after checking by running the modules (for mass4l and pT4l) and was working fine.

Okay. By eye it seems that there is an indentation issue. Since you said its running then it should be fine.

Yes, the dictionary names are identical (had to rename to generalize for other production modes) as you can check here:
616eedb

I am asking about the values in the output dictionary. Are they also same?

Yes, I checked that the values in the dictionaries I got are same for ggH and NNLOPS with both versions of the macro.

The, additional tab space appeared when I resolved conflicts. Before resolving the conflicts it was not there as you can see here:

616eedb

[ram1123]

Hi @tjavaid ,

Since, its not working it means there was an issue while you were trying to resolve the conflict.

Please check the two points again (after resolving the conflict)

1. Is the updated module working fine?
2. Is the dictionaries created by new module and the old one are identical?

And these two points are general. Whenever you resolve conflict you have to be careful. And re-check the program by running and checking the results.

[vukasinmilosevic]

@tjavaid any news on this?

[tjavaid]

@vukasinmilosevic, done with this. Please check.

[vukasinmilosevic]

Hi @ram1123 @tjavaid, this one is ready to go in?

[vukasinmilosevic]

@ram1123, @qyguo, your previous PR already include this in some form, right? Can I close this?