feat: update step 2F to exclude nodes referenced by aria-actions #235
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
cookiecrook
requested changes
Apr 25, 2024
Comment on lines
+511
to
+512
| <li id="comp_name_from_content_find_child_actions">If the <code>current node</code> has an <code>aria-actions</code> [=attribute=] with an IDREF matching the rendered child node, skip steps b-d for this child node.</li> | ||
| <li>If the <code>current node</code> has an <code>aria-actions</code> [=attribute=] with at least one valid IDREF matching any of the descendents of the rendered child node, exclude the referenced descendants from the name from content of the <code>current node</code>.</li> |
There was a problem hiding this comment.
- Can't use
IDREFlike this since it excludes the static element array plan to support references across document boundaries... (e.g.el.ariaActionsElements) - For both clarity and longevity, we shouldn't reference steps numberings like "b–d"… Reference each step by name if needed.
- This step seems like it would be a little more complicated than the proposed wording. For example, it's missing a reference to the current accname traversal. We may need to include all child nodes and then loop through with a set of exclusions (contained action reference being one of many) that remove them individually from the child nodes list. (I'm sorry I don't have a specific working suggestion.)
This was referenced May 23, 2024
Open
|
This PR has been moved to the mono repo: w3c/aria#2208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context at w3c/aria#1805, and this PR should not be merged before the ARIA PR.
Preview | Diff