Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update step 2F to exclude nodes referenced by aria-actions #235

Closed
wants to merge 1 commit into from
+2 −0
Closed

feat: update step 2F to exclude nodes referenced by aria-actions #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,8 @@ <h4>Computation steps</h4>
</li>
<li id="comp_name_from_content_for_each_child"><span id="step2F.iii"><!-- Don't link to this legacy numbered ID. --></span><em>Name From Each Child:</em> For each <code>rendered child node</code> of the <code>current node</code>:
<ol>
<li id="comp_name_from_content_find_child_actions">If the <code>current node</code> has an <code>aria-actions</code> [=attribute=] with an IDREF matching the rendered child node, skip steps b-d for this child node.</li>
<li>If the <code>current node</code> has an <code>aria-actions</code> [=attribute=] with at least one valid IDREF matching any of the descendents of the rendered child node, exclude the referenced descendants from the name from content of the <code>current node</code>.</li>
Comment on lines +511 to +512
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can't use IDREF like this since it excludes the static element array plan to support references across document boundaries... (e.g. el.ariaActionsElements)
  2. For both clarity and longevity, we shouldn't reference steps numberings like "b–d"… Reference each step by name if needed.
  3. This step seems like it would be a little more complicated than the proposed wording. For example, it's missing a reference to the current accname traversal. We may need to include all child nodes and then loop through with a set of exclusions (contained action reference being one of many) that remove them individually from the child nodes list. (I'm sorry I don't have a specific working suggestion.)

<li id="comp_name_from_content_for_each_child_set_current"><span id="step2F.iii.a"><!-- Don't link to this legacy numbered ID. --></span>Set the <code>current node</code> to the <code>rendered child node</code>.</li>
<li id="comp_name_from_content_for_each_child_recursion"><span id="step2F.iii.b"><!-- Don't link to this legacy numbered ID. --></span>Compute the text alternative of the <code>current node</code> beginning with the overall <a href="#comp_computation">Computation</a> step. Set the <code>result</code> to that text alternative.</li>
<li id="comp_for_each_child_append"><span id="step2F.iii.c"><!-- Don't link to this legacy numbered ID. --></span>Append the <code>result</code> to the <code>accumulated text</code>. </li>
Expand Down