Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browsingContext.activate #453

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Add browsingContext.activate #453

merged 7 commits into from
Jul 10, 2023

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Jun 23, 2023 •
edited by pr-preview bot
Loading

@OrKoN OrKoN force-pushed the orkon/bringToFront branch 2 times, most recently from 42c271c to 99d3ae0 Compare June 23, 2023 10:39
jgraham
jgraham requested changes Jun 26, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@thiagowfx thiagowfx changed the title Add browsingContext.bringToFront Add browsingContext.bringToFront Jun 27, 2023
@thiagowfx thiagowfx mentioned this pull request Jun 29, 2023
Closed
@OrKoN OrKoN changed the title Add browsingContext.bringToFront Add browsingContext.activate Jul 3, 2023
@whimboo
Copy link
Contributor

whimboo commented Jul 3, 2023 •
edited
Loading

@jgraham do you still have any objections? Please let us know. Otherwise I would say we could merge the PR.

@OrKoN are you going to add wdspec tests for this new command?

mathiasbynens
mathiasbynens approved these changes Jul 3, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@OrKoN
Copy link
Contributor Author

OrKoN commented Jul 4, 2023

@whimboo yes, I will start on WPT

jgraham
jgraham requested changes Jul 5, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
OrKoN
OrKoN commented Jul 5, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
jgraham
jgraham approved these changes Jul 7, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@OrKoN @jgraham
Update index.bs
28ab483 
Co-authored-by: jgraham <james@hoppipolla.co.uk>
@OrKoN
Copy link
Contributor Author

OrKoN commented Jul 10, 2023

I will start working on WPT tests this week.

@jgraham jgraham merged commit 6736ff3 into w3c:master Jul 10, 2023
3 checks passed
github-actions bot added a commit that referenced this pull request Jul 10, 2023
@OrKoN @github-actions
Add browsingContext.activate (#453)
dcd8c85 
SHA: 6736ff3
Reason: push, by jgraham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@OrKoN OrKoN deleted the orkon/bringToFront branch July 10, 2023 09:50
@OrKoN OrKoN mentioned this pull request Jul 11, 2023
Merged
@OrKoN
Copy link
Contributor Author

OrKoN commented Jul 11, 2023

Draft tests web-platform-tests/wpt#40964

@OrKoN OrKoN mentioned this pull request Jul 11, 2023
Merged
OrKoN added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Jul 12, 2023
@OrKoN
feat: implement browsingContext.activate (#1002)
22e2417 
WPT: web-platform-tests/wpt#40964
Spec: w3c/webdriver-bidi#453
@OrKoN OrKoN mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whimboo whimboo whimboo left review comments

@jrandolf-2 jrandolf-2 jrandolf-2 left review comments

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@jgraham jgraham jgraham approved these changes

@thiagowfx thiagowfx thiagowfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OrKoN @whimboo @mathiasbynens @jgraham @thiagowfx @jrandolf-2