Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebDriver BiDi: add tests for browsingContext.activate #40964

Merged
merged 3 commits into from
Jul 13, 2023
Merged

WebDriver BiDi: add tests for browsingContext.activate #40964

merged 3 commits into from
Jul 13, 2023

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Jul 11, 2023

@OrKoN OrKoN mentioned this pull request Jul 11, 2023
Merged
@OrKoN OrKoN mentioned this pull request Jul 11, 2023
Merged
thiagowfx pushed a commit that referenced this pull request Jul 11, 2023
add activate stub from #40964
3a0cef3
OrKoN added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Jul 12, 2023
@OrKoN
feat: implement browsingContext.activate (#1002)
22e2417 
WPT: web-platform-tests/wpt#40964
Spec: w3c/webdriver-bidi#453
@OrKoN OrKoN marked this pull request as ready for review July 12, 2023 08:42
@OrKoN
Copy link
Contributor Author

OrKoN commented Jul 12, 2023

@thiagowfx PTAL again

@wpt-pr-bot wpt-pr-bot added infra webdriver webdriver-bidi wg-testing_browser wptrunner The automated test runner, commonly called through ./wpt run labels Jul 12, 2023
@OrKoN
Copy link
Contributor Author

OrKoN commented Jul 12, 2023

@juliandescottes PTAL

@OrKoN OrKoN requested a review from lutien July 13, 2023 12:57
lutien
lutien approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@lutien lutien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alex!

@OrKoN
Copy link
Contributor Author

OrKoN commented Jul 13, 2023

@DanielRyanSmith could you please admin-merge this one?

@DanielRyanSmith DanielRyanSmith merged commit 6803a09 into web-platform-tests:master Jul 13, 2023
39 of 41 checks passed
@OrKoN OrKoN deleted the orkon/activate branch July 13, 2023 15:24
thiagowfx pushed a commit that referenced this pull request Jul 21, 2023
add activate stub from #40964
2df0087
DanielRyanSmith pushed a commit that referenced this pull request Jul 21, 2023
[wdspec] add test: activate before taking screenshot (#40965)
88f0962 
* screenshot: invalid: add empty context

* add activate stub from #40964

* add activate step in capture_screenshot test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@thiagowfx thiagowfx thiagowfx approved these changes

@lutien lutien lutien approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

@foolip foolip Awaiting requested review from foolip

@jgraham jgraham Awaiting requested review from jgraham

@jrandolf-2 jrandolf-2 Awaiting requested review from jrandolf-2

@juliandescottes juliandescottes Awaiting requested review from juliandescottes

@sadym-chromium sadym-chromium Awaiting requested review from sadym-chromium

@shs96c shs96c Awaiting requested review from shs96c

@whimboo whimboo Awaiting requested review from whimboo

Assignees

@OrKoN OrKoN

Labels
infra webdriver webdriver-bidi wg-testing_browser wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OrKoN @mathiasbynens @thiagowfx @lutien @wpt-pr-bot @DanielRyanSmith