Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES6+ Syntax & API Separation #1

Closed
wants to merge 65 commits into from
Closed

ES6+ Syntax & API Separation #1

wants to merge 65 commits into from

Conversation

walmat
Copy link
Owner

@walmat walmat commented Nov 16, 2019

No description provided.

walmat and others added 26 commits November 16, 2019 16:35
@walmat
es6 rewrite, modularity improvements, and updated readme
9c76e96
@walmat
Update index.js
b25be38
@walmat
added babel transformer
46520e6
@walmat
merge upstream
24489d5
@walmat
revert cached git store
468040b
@walmat
fix entry point and small bugs
6b21b0d
@walmat
Update README.md
440c8d2
@walmat
some bug fixes and examples
96041c0
@walmat
Merge branch 'es6-rewrite' of https://github.com/walmat/stockx-api in…
3f6fc66 
…to es6-rewrite
@walmat
added a few examples
4570235
@walmat
switch to node-fetch
e8fd001
@walmat
readded base url
615e777
@walmat
few fetch bugs fixed
6abd3f0
@walmat
bug fixes with OAuth
6e20134
@walmat
implemented dotenv to protect sensitive data
dfd0909
@walmat
revert to request-promise-native and more bug fixes and qol improvements
226a4df
@walmat
small bug with inclusive range fixed
aed5527
@walmat
implemented singleton and fixed some request-promise issues
e5f0973
@walmat
Update README.md
f26685a
@walmat
Update README.md
0fdf2b9
@walmat
updated example
f96e116
@walmat
cleanup duplicate headers
b5352a4
@walmat
added better error messages
1f4867a
@walmat
added better error messages
0111cf2
@matthew1232
Fixed callback submission
a3fa634
@walmat
Merge pull request #2 from matthew1232/patch-1
60051b2 
Fixed callback submission
@walmat
Copy link
Owner Author

walmat commented Nov 19, 2019 •
edited
Loading

Manual Checks to test:

  • Can the user successfully login
  • Can the user place an ask
  • Can a user update that previously placed ask
  • Can a user place a bid
  • Can a user update that previously placed bid
  • ..anything else?

@walmat
Copy link
Owner Author

walmat commented Nov 19, 2019

@matthew1232 let me know what is left to test, I'll run through a code review of this right now in it's current state.

walmat
walmat commented Nov 19, 2019
View reviewed changes
Copy link
Owner Author

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass done.

examples/index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
click2install
click2install reviewed Nov 19, 2019
View reviewed changes
Copy link
Collaborator

@click2install click2install left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general observations. Not sure at what stage the PR is at, most comments are w.r.t the code being made more DRY and a few small other observations.

src/apis/stockx/asks/index.js Outdated Show resolved Hide resolved
src/apis/stockx/asks/index.js Outdated Show resolved Hide resolved
src/apis/stockx/asks/index.js Outdated Show resolved Hide resolved
src/apis/stockx/index.js Outdated Show resolved Hide resolved
src/apis/stockx/user/helpers.js Show resolved Hide resolved
src/apis/stockx/index.js Outdated Show resolved Hide resolved
matthew1232 and others added 22 commits November 20, 2019 14:02
@matthew1232
Updated error handling, removed unnecessary error bubbling, adding re…
c46f5ba 
…moving asks
@walmat
Merge pull request #4 from matthew1232/patch-3
62b209d 
Login credential status/general request errors
@walmat
Merge pull request #5 from matthew1232/patch-4
3d7acbc 
Implementing error handling from utils and changed checkStatus to submitCallback
@walmat
Merge pull request #7 from matthew1232/patch-6
a20d186 
Removed unnecessary error bubbling
@matthew1232
Include 304 as accepted status code
277c80c
@matthew1232 @walmat
Update src/apis/stockx/asks/index.js
3f5dfdb 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232 @walmat
Update src/apis/stockx/asks/index.js
040d213 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232 @walmat
Update src/apis/stockx/asks/index.js
31f528f 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232 @walmat
Update src/apis/stockx/asks/index.js
0859e92 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232 @walmat
Update src/apis/stockx/bids/index.js
fb2c9e1 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232 @walmat
Update src/apis/stockx/bids/index.js
8778aa2 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232 @walmat
Update src/apis/stockx/bids/index.js
0f35819 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232 @walmat
Update src/apis/stockx/bids/index.js
0bd8ea0 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@walmat
Merge pull request #10 from matthew1232/patch-10
d6b8f10 
Include 304 as accepted status code
@matthew1232
Import error handling into utils
1593bdb
@walmat
Merge pull request #11 from matthew1232/patch-11
df4494d 
Import error handling into utils
@matthew1232
Import utils from index
dde316d
@matthew1232 @walmat
Update src/apis/stockx/bids/index.js
11029f5 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232
Update index.js
89b35aa
@walmat
Merge pull request #9 from matthew1232/patch-9
d78759f 
Updated error handling, removed unnecessary error bubbling, adding re…
@matthew1232 @walmat
Update src/apis/stockx/bids/index.js
f25c847 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@matthew1232 @walmat
Update src/apis/stockx/bids/index.js
2101dc1 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
walmat
walmat commented Nov 25, 2019
View reviewed changes
Copy link
Owner Author

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened remaining separate issues and resolved. Should re-validate manual checks before merging!

matthew1232 and others added 6 commits November 24, 2019 20:39
@matthew1232 @walmat
Update src/apis/stockx/bids/index.js
b436112 
Co-Authored-By: Matthew Wall <matthew.wallt@gmail.com>
@walmat
Merge pull request #8 from matthew1232/patch-8
29093fe 
Added deleting bids, implemented checking status from utils
@matthew1232
Add error handling from utils
40846b4 
Allowed objects from products.search, fixed error handling and removed error bubbling that was unneeded.
@walmat
Merge pull request #13 from matthew1232/patch-8
67265f5 
Add error handling from utils
@matthew1232
Remove renamed variables (fatal)
e94d8fc
@walmat
Merge pull request #18 from matthew1232/patch-13
2e81a28 
Remove renamed variables (fatal)
@walmat walmat closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew1232 matthew1232 matthew1232 left review comments

@click2install click2install click2install left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walmat @click2install @matthew1232