Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6+ Syntax & API Separation #1

Closed
wants to merge 65 commits into from
Closed
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
9c76e96
es6 rewrite, modularity improvements, and updated readme
walmat Nov 16, 2019
b25be38
Update index.js
walmat Nov 16, 2019
46520e6
added babel transformer
walmat Nov 16, 2019
24489d5
merge upstream
walmat Nov 16, 2019
468040b
revert cached git store
walmat Nov 16, 2019
6b21b0d
fix entry point and small bugs
walmat Nov 16, 2019
440c8d2
Update README.md
walmat Nov 16, 2019
96041c0
some bug fixes and examples
walmat Nov 17, 2019
3f6fc66
Merge branch 'es6-rewrite' of https://github.com/walmat/stockx-api in…
walmat Nov 17, 2019
4570235
added a few examples
walmat Nov 17, 2019
e8fd001
switch to node-fetch
walmat Nov 17, 2019
615e777
readded base url
walmat Nov 17, 2019
6abd3f0
few fetch bugs fixed
walmat Nov 17, 2019
6e20134
bug fixes with OAuth
walmat Nov 17, 2019
dfd0909
implemented dotenv to protect sensitive data
walmat Nov 17, 2019
226a4df
revert to request-promise-native and more bug fixes and qol improvements
walmat Nov 18, 2019
aed5527
small bug with inclusive range fixed
walmat Nov 18, 2019
e5f0973
implemented singleton and fixed some request-promise issues
walmat Nov 18, 2019
f26685a
Update README.md
walmat Nov 18, 2019
0fdf2b9
Update README.md
walmat Nov 18, 2019
f96e116
updated example
walmat Nov 18, 2019
b5352a4
cleanup duplicate headers
walmat Nov 18, 2019
1f4867a
added better error messages
walmat Nov 18, 2019
0111cf2
added better error messages
walmat Nov 18, 2019
a3fa634
Fixed callback submission
matthew1232 Nov 19, 2019
60051b2
Merge pull request #2 from matthew1232/patch-1
walmat Nov 19, 2019
17fcd50
Apply suggestions from code review
walmat Nov 19, 2019
079fe55
fixed shared context, exposed shared context mutations, added shared …
walmat Nov 19, 2019
0e197ed
fix bug with placing ask/bid
walmat Nov 19, 2019
f6cc92a
updated examples to update ask
walmat Nov 19, 2019
eb70706
updated description
walmat Nov 19, 2019
ba8b94f
fixed broken links in readme, added contributing guidelines
walmat Nov 19, 2019
8ed658e
Update README.md
walmat Nov 19, 2019
03300b3
Login credential status/general request errors
matthew1232 Nov 20, 2019
c86e623
Implementing error handling from utils
matthew1232 Nov 20, 2019
5422a5d
Removed unnecessary error bubbling
matthew1232 Nov 20, 2019
663ab40
Added deleting bids, implemented checking status from utils
matthew1232 Nov 20, 2019
c46f5ba
Updated error handling, removed unnecessary error bubbling, adding re…
matthew1232 Nov 20, 2019
62b209d
Merge pull request #4 from matthew1232/patch-3
walmat Nov 21, 2019
3d7acbc
Merge pull request #5 from matthew1232/patch-4
walmat Nov 21, 2019
a20d186
Merge pull request #7 from matthew1232/patch-6
walmat Nov 21, 2019
277c80c
Include 304 as accepted status code
matthew1232 Nov 21, 2019
3f5dfdb
Update src/apis/stockx/asks/index.js
matthew1232 Nov 21, 2019
040d213
Update src/apis/stockx/asks/index.js
matthew1232 Nov 21, 2019
31f528f
Update src/apis/stockx/asks/index.js
matthew1232 Nov 21, 2019
0859e92
Update src/apis/stockx/asks/index.js
matthew1232 Nov 21, 2019
fb2c9e1
Update src/apis/stockx/bids/index.js
matthew1232 Nov 21, 2019
8778aa2
Update src/apis/stockx/bids/index.js
matthew1232 Nov 21, 2019
0f35819
Update src/apis/stockx/bids/index.js
matthew1232 Nov 21, 2019
0bd8ea0
Update src/apis/stockx/bids/index.js
matthew1232 Nov 21, 2019
d6b8f10
Merge pull request #10 from matthew1232/patch-10
walmat Nov 21, 2019
1593bdb
Import error handling into utils
matthew1232 Nov 21, 2019
df4494d
Merge pull request #11 from matthew1232/patch-11
walmat Nov 21, 2019
dde316d
Import utils from index
matthew1232 Nov 21, 2019
11029f5
Update src/apis/stockx/bids/index.js
matthew1232 Nov 22, 2019
89b35aa
Update index.js
matthew1232 Nov 22, 2019
d78759f
Merge pull request #9 from matthew1232/patch-9
walmat Nov 22, 2019
f25c847
Update src/apis/stockx/bids/index.js
matthew1232 Nov 25, 2019
2101dc1
Update src/apis/stockx/bids/index.js
matthew1232 Nov 25, 2019
b436112
Update src/apis/stockx/bids/index.js
matthew1232 Nov 25, 2019
29093fe
Merge pull request #8 from matthew1232/patch-8
walmat Nov 25, 2019
40846b4
Add error handling from utils
matthew1232 Nov 25, 2019
67265f5
Merge pull request #13 from matthew1232/patch-8
walmat Nov 25, 2019
e94d8fc
Remove renamed variables (fatal)
matthew1232 Nov 25, 2019
2e81a28
Merge pull request #18 from matthew1232/patch-13
walmat Nov 28, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
root = true

[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
indent_size = 4
trim_trailing_whitespace = false
3 changes: 3 additions & 0 deletions .env.sample
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# rename this file to `.env`
username=''
password=
16 changes: 16 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
module.exports = {
env: {
es6: true,
},
extends: ['airbnb-base', 'prettier'],
parserOptions: {
ecmaFeatures: { jsx: false }, // to be overridden as necessary
ecmaVersion: 2018,
},
plugins: ['prettier', 'react', 'import', 'jsx-a11y'],
rules: {
'prettier/prettier': 'error',
'no-underscore-dangle': 'off',
'camelcase': 'warn',
},
};
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
Please make sure you check the list of open issues before posting an issue

## Expected Behavior
<!--- If you're describing a bug, tell us what should happen -->
<!--- If you're suggesting a change/improvement, tell us how it should work -->

## Current Behavior
<!--- If describing a bug, tell us what happens instead of the expected behavior -->
<!--- If suggesting a change/improvement, explain the difference from current behavior -->

## Possible Solution
<!--- Not obligatory, but suggest a fix/reason for the bug, -->
<!--- or ideas how to implement the addition or change -->

## Steps to Reproduce (if necessary)
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.

## Context
<!--- How has this issue affected you? What are you trying to accomplish? -->
<!--- Providing context helps us come up with a solution that is most useful in the real world -->

## Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
35 changes: 35 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
Please search amongst the open [Pull Requests](../) before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
For more information, see the `CONTRIBUTING` guidelines.

**Summary**

<!-- Summary of the PR -->

This PR fixes/implements the following **bugs/features**

* [ ] Bug 1
* [ ] Bug 2
* [ ] Feature 1
* [ ] Feature 2
* [ ] Breaking changes

<!-- You can skip this if you're fixing a typo or adding an app to the Showcase. -->

Explain the **motivation** for making this change. What existing problem does the pull request solve?

<!-- Example: When "Adding a function to do X", explain why it is necessary to have a way to do X. -->

**Test plan (required)**

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

**Code formatting**

<!-- See the simple style guide. -->

**Closing issues**

<!-- Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such). -->
Fixes #
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
dist/
node_modules
test.js
.DS_Store
.DS_Store
.env
52 changes: 52 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
module.exports = {
arrowParens: "avoid",
bracketSpacing: true,
endOfLine: "lf",
jsxBracketSameLine: false,
printWidth: 80,
singleQuote: true,
tabWidth: 2,
trailingComma: "all",
useTabs: false,
overrides: [
{
files: ["*.js", "*.jsx", "*.es", "*.es6", "*.mjs"],
options: {
printWidth: 100,
parser: "babel"
}
},
{
files: ["*.json"],
excludeFiles: ["package.json"],
options: {
parser: "json"
}
},

{
files: ["*.css", "*.css3", "*.css4"],
options: {
parser: "css"
}
},
{
files: ["*.scss"],
options: {
parser: "scss"
}
},
{
files: ["*.htm", "*.html"],
options: {
parser: "html"
}
},
{
files: ["*.md", "*.mdown"],
options: {
parser: "markdown"
}
}
]
};
9 changes: 9 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"recommendations": [
"2gua.rainbow-brackets",
"christian-kohler.path-intellisense",
"christian-kohler.npm-intellisense",
"dbaeumer.vscode-eslint",
"editorconfig.editorconfig"
]
}
Loading