-
Notifications
You must be signed in to change notification settings - Fork 42
Add CI that builds CloudFlare Pages previews on forks #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudFlare Pages integration doesn't run on forks. But, because the forks are public, we can do custom CI that manually `git clone`s those forks, and, after checking them out, runs the CloudFlare Pages build for us, commenting back in the originating PR with a link.
Deploying docs with
|
| Latest commit: |
e0a009d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5a50244.docodile.pages.dev |
| Branch Preview URL: | https://forks-build-on-cloudflare.docodile.pages.dev |
ngrayluna
approved these changes
Mar 21, 2025
Contributor
ngrayluna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question (for my understanding). Otherwise looks good.
| fi | ||
| # Debug directory structure | ||
| - name: Debug directory structure |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens w/out these checks? Curious what errors you were hitting.
Mission 1 of this PR: To improve some things that are currently a bit awkward in the quickstart. Mission 2: Testing new functionality that deploys CloudFlare preview builds on PRs created from forks. (See the GitHub Actions comment/CloudFlare links below) Mission 2 is why this PR targets the `forks-build-on-cloudflare` branch (so you can see the CI in action), and is also why the correct merge order is: this PR first, then #1205 after to finally publish into main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudFlare Pages integration doesn't run on forks. But, because the forks are public, we can do custom CI that manually
git clones those forks, and, after checking them out, runs the CloudFlare Pages build for us, commenting back in the originating PR with a link.See #1206 for an example of this CI in action