Skip to content

Conversation

@johndmulhausen
Copy link
Contributor

@johndmulhausen johndmulhausen commented Mar 21, 2025

Mission 1 of this PR: To improve some things that are currently a bit awkward in the quickstart.
Mission 2: Testing new functionality that deploys CloudFlare preview builds on PRs created from forks. (See the GitHub Actions comment/CloudFlare links below)

Mission 2 is why this PR targets the forks-build-on-cloudflare branch (so you can see the CI in action), and is also why the correct merge order is: this PR first, then #1205 after to finally publish into main.

@johndmulhausen johndmulhausen requested a review from a team as a code owner March 21, 2025 03:30
@johndmulhausen johndmulhausen added WIP DO-NOT-MERGE For PRs that should not be merged yet labels Mar 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

🚀 PR Preview deployed successfully!

📝 Preview URL: https://223cf0fc.docodile.pages.dev

✅ Last built: 2025-03-21 18:13:31 UTC
📌 Commit: 07556e0
🔍 View build details

This preview was automatically generated from fork PR johndmulhausen:forks-build-on-cloudflare.

@johndmulhausen johndmulhausen removed WIP DO-NOT-MERGE For PRs that should not be merged yet labels Mar 21, 2025
@johndmulhausen johndmulhausen changed the title Testing CI: Update quickstart.md Minor improvements to Quickstart Mar 21, 2025
@johndmulhausen johndmulhausen changed the base branch from forks-build-on-cloudflare to main March 21, 2025 18:07
@johndmulhausen johndmulhausen changed the base branch from main to forks-build-on-cloudflare March 21, 2025 18:09
@johndmulhausen johndmulhausen merged commit 26b08ca into wandb:forks-build-on-cloudflare Mar 21, 2025
5 checks passed
johndmulhausen added a commit that referenced this pull request Mar 21, 2025
CloudFlare Pages integration doesn't run on forks. But, because the
forks are public, we can do custom CI that manually `git clone`s those
forks, and, after checking them out, runs the CloudFlare Pages build for
us, commenting back in the originating PR with a link.

See #1206 for an example of this CI in action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants