fix(chart): reference the correct value for the Jetstream domain #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protochron
force-pushed
the
wadm_chart_domain
branch
2 times, most recently
from
d577881
to
4f2ccee
Compare
Pull the `jetstreamDomain` value from `config.wadm.nats.jetstreamDomain` instead of from `config.wadm.jetstreamDomain` since that is what we define in the values file. It is also a more logical way to group the value than what the chart was expecting. Also bump the default version of wadm to the latest one. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
protochron
force-pushed
the
wadm_chart_domain
branch
from
4f2ccee
to
d3d9ef2
Compare
joonas
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Pull the
jetstreamDomainvalue fromconfig.wadm.nats.jetstreamDomaininstead of fromconfig.wadm.jetstreamDomainsince that is what we define in the values file. It is also a more logical way to group the value than what the chart was expecting.Related Issues
Release Information
Next chart release
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification