Use SVG versions of the banner #521
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranjoMindek
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Great initiative.
Just check how this works with prettier before the merge:
#518 (comment)
| import { Link as WaspRouterLink, routes } from "wasp/client/router"; | ||
| import openSaasBannerDark from "../../client/static/open-saas-banner-dark.png"; | ||
| import openSaasBannerLight from "../../client/static/open-saas-banner-light.png"; | ||
| import openSaasBannerDark from "../../client/static/open-saas-banner-dark.svg"; |
There was a problem hiding this comment.
IIRC loading SVG files through <img> element is not recommended.
But I think it's fine here because we literally use it as an image.
Usual reasons are:
- bad for performance of small SVG icons
- lose the option of styling the SVG through classes (stroke, fill...)
There was a problem hiding this comment.
Yep, this doesn't apply here as we're literally just using an image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
templatesize #516Before
After