Skip to content

Use SVG versions of the banner #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Use SVG versions of the banner #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3525d50
Use SVG versions of the banner
cprecioso Oct 1, 2025
273d56f
Merge remote-tracking branch 'origin/main' into cprecioso/use-svg
cprecioso Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opensaas-sh/app_diff/deletions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
src/client/static/open-saas-banner-dark.png
src/client/static/open-saas-banner-light.png
src/client/static/open-saas-banner-dark.svg
src/client/static/open-saas-banner-light.svg
src/landing-page/components/Hero.tsx
src/landing-page/contentSections.ts
src/payment/lemonSqueezy/checkoutUtils.ts
Expand Down
Binary file removed template/app/src/client/static/open-saas-banner-dark.png
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions template/app/src/client/static/open-saas-banner-dark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed template/app/src/client/static/open-saas-banner-light.png
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions template/app/src/client/static/open-saas-banner-light.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions template/app/src/landing-page/components/Hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Link as WaspRouterLink, routes } from "wasp/client/router";
import openSaasBannerDark from "../../client/static/open-saas-banner-dark.png";
import openSaasBannerLight from "../../client/static/open-saas-banner-light.png";
import openSaasBannerDark from "../../client/static/open-saas-banner-dark.svg";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC loading SVG files through <img> element is not recommended.
But I think it's fine here because we literally use it as an image.

Usual reasons are:

  • bad for performance of small SVG icons
  • lose the option of styling the SVG through classes (stroke, fill...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this doesn't apply here as we're literally just using an image.

import openSaasBannerLight from "../../client/static/open-saas-banner-light.svg";
import { Button } from "../../components/ui/button";

export default function Hero() {
Expand Down